Setup the geos python package CI #4
Conversation
|
@TotoGaz - any thoughts on the CI configuration? I'm building off of the github template for python packages here. Do you want to add/remove any python versions? Also, I've commented out the linting and testing steps for now, as we haven't been enforcing these yet. |
.github/workflows/python-package.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Is it possible to have python 3.8? I kind of remember there are some differences for type hints starting python 3.9.
Those differences were popping errors on ubuntu 20.04 (IIRC) but the differences are not worth ditching 3.8 from the supported platforms.
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: mpi4py/setup-mpi@v1 |
There was a problem hiding this comment.
Do we want to rely on this or should we prefer installing from requirements.txt?
There was a problem hiding this comment.
These help to setup the underlying python and mpi environments (needed for mpi4py to not throw an error). We could probably roll our own, but these actions seem to be quite reliable.
No description provided.